Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Jan 23, 2025

🧭 What and Why

Following #4392, we can use a custom linter to verify that type is present and matches what we expect.

@millotp millotp requested a review from a team as a code owner January 23, 2025 14:45
@millotp millotp requested review from Fluf22 and morganleroi January 23, 2025 14:45
@millotp millotp self-assigned this Jan 23, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 23, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 160f23a8b208dd48b22bd8f91131c3a8e8231a79
🍃 Generated commit 6185ec3c61aa898b9e00145c83a60643b17f5e48
🌲 Generated branch generated/fix/more-type
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1661
javascript 1642
php 1447
csharp 1390
python 1082
java 1082
ruby 819
swift 750

@github-actions
Copy link

github-actions bot commented Jan 23, 2025

Fluf22
Fluf22 previously approved these changes Jan 27, 2025
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@millotp millotp merged commit 09e657f into main Jan 27, 2025
28 checks passed
@millotp millotp deleted the fix/more-type branch January 27, 2025 10:36
algolia-bot added a commit that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 27, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants